Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP run Ironic on the bootstrap VM #642

Merged
merged 7 commits into from
Aug 16, 2019
Merged

WIP run Ironic on the bootstrap VM #642

merged 7 commits into from
Aug 16, 2019

Conversation

hardys
Copy link

@hardys hardys commented Jun 25, 2019

This is to test with openshift-metal3/kni-installer#100

@hardys
Copy link
Author

hardys commented Jun 25, 2019

TODO is updating the readme/docs to show how to access the baremetal IP of the bootstrap VM with openstackclient.

@hardys hardys added the CI check this PR with CI label Jun 25, 2019
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@hardys hardys force-pushed the bootstrap_ironic branch from 56ff917 to 09bc47d Compare June 26, 2019 12:02
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@hardys hardys force-pushed the bootstrap_ironic branch 2 times, most recently from 51e22cf to e4bb177 Compare June 26, 2019 14:32
@metal3ci

This comment has been minimized.

Sign in to view
@hardys hardys removed the CI check this PR with CI label Jun 27, 2019
@hardys hardys force-pushed the bootstrap_ironic branch 2 times, most recently from 374e934 to 1c5fddc Compare July 16, 2019 12:56
@hardys hardys added the CI check this PR with CI label Jul 16, 2019
@hardys hardys mentioned this pull request Jul 16, 2019
Closed
@metal3ci

This comment has been minimized.

Sign in to view
derekhiggins
derekhiggins reviewed Jul 16, 2019
View reviewed changes
04_setup_ironic.sh
-v $IRONIC_DATA_DIR:/shared --entrypoint /bin/rundnsmasq ${IRONIC_IMAGE}

# We start only the httpd and *downloader containers so that we can provide
# cached images to the bootstrap VM
sudo podman run -d --net host --privileged --name httpd --pod ironic-pod \
-v $IRONIC_DATA_DIR:/shared --entrypoint /bin/runhttpd ${IRONIC_IMAGE}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be getting used during the deploy (IPA is downlownloading it from this container), I guess the URLs need to change here

dev-scripts/make-bm-worker/main.go

Line 13 in d540fd8

instanceImageSource = "http://172.22.0.1/images/rhcos-ootpa-latest.qcow2"

and

dev-scripts/ocp_install_env.sh

Line 80 in d540fd8

source: "http://172.22.0.1/images/$RHCOS_IMAGE_FILENAME_LATEST"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good point, I'll change it in the install-config for now - ultimately I'd like to remove the image from there and just reference it inside the installer, fixing openshift-metal3/kni-installer#58

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so it turns out this won't work, because the image URL/checksum passed via the install-config is used for both terraform to deploy the masters, and also to set the Image on the providerSpec for the worker machineset.

So I think we'll have to fix openshift-metal3/kni-installer#58 and remove that install-config interface, such that we can internally decouple the two different image locations. Digging into that now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest version in openshift/installer#2079 should resolve this I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work, is the idea the bootstrap should get the image from the httpd pod running on the provisioning host? It's currently downloading from the openshift URL, which is very slow from some of our boxes. In fact, on my hardware in one of data centers, I get a lousy 150kbps, which takes longer than 30 min -- and thus the installer timeout -- to download RHCOS. I'm wondering if that's why we haven't seen this pass in CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local caching wasn't working because the hardcoded RHCOS image in dev-scripts didn't match the new version in the installer. I pushed an update here, so the newer RHCOS does get downloaded and cached.

It will never work in CI as written, because we don't cache the RHCOS images in CI. This is trickier to solve, but I'll try fixing it once I actually get the rest of the stuff working on my local box.

@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@hardys hardys force-pushed the bootstrap_ironic branch from 9c78bd0 to d49332d Compare July 17, 2019 10:46
@metal3ci

This comment has been minimized.

Sign in to view
@hardys hardys force-pushed the bootstrap_ironic branch from d49332d to 909561c Compare July 24, 2019 14:35
@hardys hardys removed the CI check this PR with CI label Jul 24, 2019
@hardys hardys mentioned this pull request Jul 24, 2019
Merged
@hardys hardys force-pushed the bootstrap_ironic branch from 909561c to 1d76dfa Compare July 24, 2019 15:13
@hardys hardys added the CI check this PR with CI label Jul 24, 2019
@metal3ci

This comment has been minimized.

Sign in to view
@hardys hardys force-pushed the bootstrap_ironic branch from 1d76dfa to 70bbe2d Compare July 25, 2019 10:45
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci
Copy link

metal3ci commented Aug 2, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/995/

@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci

This comment has been minimized.

Sign in to view
@metal3ci
Copy link

metal3ci commented Aug 5, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1003/

@stbenjam stbenjam mentioned this pull request Aug 5, 2019
Merged
@stbenjam
Copy link
Member

stbenjam commented Aug 5, 2019

CI is passing. We'll need a new openshift release once the installer PR is merged.

@dtantsur
Copy link
Member

dtantsur commented Aug 6, 2019

🎉 Now we need a way for the CI to retrieve the ramdisk logs (that are stored as tarballs in the shared location).

This was referenced Aug 8, 2019
Closed
Merged
@russellb russellb merged commit 39ecf79 into openshift-metal3:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins derekhiggins left review comments

@stbenjam stbenjam stbenjam left review comments

Assignees
No one assigned
Labels
CI check this PR with CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hardys @metal3ci @stbenjam @dtantsur @derekhiggins @russellb