This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Merge openshift/installer 4.1.0 rc.5 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds sudo when gathering rendered-assets within /usr/local/bin/installer-gather.sh. It also changes the owner and permissions on the copied files so that the core user has access to read them. In addition, the method used to retrieve assets from the control-plane nodes has been modified to make it less noisy on error.
Bug 1708307: bootstrap/files: installer-gather.sh to gather more rendered-assets
openstack: fix comments from 1733
Fix the UPI's Readme deploy-packet url
Bug 1707096: gather: suffix container logs with container ids for uniqueness
[openstack] More robust deprovision strategy
…1750-to-release-4.1 Bug 1709869: tls: add openshift service to DNS names
…lete PR for cluster-machine-approver [1] is taking over the approval of CSRs for client certificates for Machines that end up as Nodes in Openshift clusters. But during bootstrapping, cluster-machine-approver is not available and therefore, this service is required to approve CSRs until we have successfully bootstrapped the control plane, after which cluster-machine-approver or users take over the role of approving any new CSRs. Currently, all CSRs are automatically approved without any condition, this PR scopes it to only during bootstrapping phase, securing the endpoint for later use. [1]: openshift/cluster-machine-approver#26
…1747-to-release-4.1 [release-4.1] data: add approve-csr service to approve CSRs until bootstrap is complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.