OCM-2941 | fix: Adjusting help usage and ingress builder call

openshift-online · Jul 26, 2023 · 743111a · 743111a
1 parent f8bd39d
commit 743111a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cmd/ocm/create/cluster/cmd.go b/cmd/ocm/create/cluster/cmd.go
@@ -275,7 +275,8 @@ func init() {
 		defaultIngressRouteSelectorFlag,
 		"",
 		"Route Selector for ingress. Format should be a comma-separated list of 'key=value'. "+
-			"If no label is specified, all routes will be exposed on both routers.",
+			"If no label is specified, all routes will be exposed on both routers."+
+			" For legacy ingress support these are inclusion labels, otherwise they are treated as exclusion label.",
 	)
 
 	fs.StringVar(

diff --git a/cmd/ocm/edit/ingress/cmd.go b/cmd/ocm/edit/ingress/cmd.go
@@ -101,7 +101,8 @@ func init() {
 		routeSelectorFlag,
 		"",
 		"Route Selector for ingress. Format should be a comma-separated list of 'key=value'. "+
-			"If no label is specified, all routes will be exposed on both routers.",
+			"If no label is specified, all routes will be exposed on both routers."+
+			" For legacy ingress support these are inclusion labels, otherwise they are treated as exclusion label.",
 	)
 
 	flags.StringVar(
@@ -295,7 +296,7 @@ func run(cmd *cobra.Command, argv []string) error {
 		if cluster.Hypershift().Enabled() {
 			return fmt.Errorf("Can't edit `%s` for Hosted Control Plane clusters", clusterRoutesTlsSecretRefFlag)
 		}
-		ingressBuilder = ingressBuilder.ClusterRoutesHostname(args.clusterRoutesTlsSecretRef)
+		ingressBuilder = ingressBuilder.ClusterRoutesTlsSecretRef(args.clusterRoutesTlsSecretRef)
 	}
 
 	ingress, err = ingressBuilder.Build()