Skip to content

Commit

Permalink
Adds delete and create verbs to validating webhook
Browse files Browse the repository at this point in the history
When manual approval is shiped in operator, webhook gives an error
as it cannot set an ownerRef on a resource which it can't delete

Hence this patch fixes this by adding missing verbs

Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
  • Loading branch information
PuneetPunamiya committed Jun 13, 2024
1 parent 89b1dde commit b59711e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/openshift/201-clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ rules:
resourceNames: ["webhook.manual.approval.dev"]
# When there are changes to the configs or secrets, knative updates the validatingwebhook config
# with the updated certificates or the refreshed set of rules.
verbs: ["get", "list", "update", "patch", "watch"]
verbs: ["get", "list", "update", "patch", "watch", "delete", "create"]
- apiGroups: [ "openshift-pipelines.org" ]
resources: [ "approvaltasks" ]
verbs: [ "get", "list", "create", "update", "delete", "patch", "watch" ]
Expand Down

0 comments on commit b59711e

Please sign in to comment.