Skip to content

Commit

Permalink
Adds event name in skipped event logs
Browse files Browse the repository at this point in the history
this adds event name in skipped event logs to know which event it was
previous:-
  skipping event: unsupported action "completed"
now:-
  skipping event: check_run: unsupported action "completed"

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
  • Loading branch information
Shivam Mukhade committed Apr 26, 2022
1 parent 086f99e commit ea60d90
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pkg/provider/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ func (v *Provider) Detect(reqHeader *http.Header, payload string, logger *zap.Su
if gitEvent.GetAction() == "rerequested" && gitEvent.GetCheckRun() != nil {
return setLoggerAndProceed(true, "", nil)
}
return setLoggerAndProceed(false, fmt.Sprintf("unsupported action \"%s\"", gitEvent.GetAction()), nil)
return setLoggerAndProceed(false, fmt.Sprintf("check_run: unsupported action \"%s\"", gitEvent.GetAction()), nil)

case *github.IssueCommentEvent:
if gitEvent.GetAction() == "created" &&
Expand All @@ -260,18 +260,18 @@ func (v *Provider) Detect(reqHeader *http.Header, payload string, logger *zap.Su
}
return setLoggerAndProceed(false, "", nil)
}
return setLoggerAndProceed(false, "not a gitops pull request comment", nil)
return setLoggerAndProceed(false, "issue: not a gitops pull request comment", nil)
case *github.PushEvent:
if gitEvent.GetPusher() != nil {
return setLoggerAndProceed(true, "", nil)
}
return setLoggerAndProceed(false, "no push in event", nil)
return setLoggerAndProceed(false, "push: no pusher in event", nil)

case *github.PullRequestEvent:
if provider.Valid(gitEvent.GetAction(), []string{"opened", "synchronize", "reopened"}) {
return setLoggerAndProceed(true, "", nil)
}
return setLoggerAndProceed(false, fmt.Sprintf("unsupported action \"%s\"", gitEvent.GetAction()), nil)
return setLoggerAndProceed(false, fmt.Sprintf("pull_request: unsupported action \"%s\"", gitEvent.GetAction()), nil)

default:
return setLoggerAndProceed(false, fmt.Sprintf("github: event \"%v\" is not supported", event), nil)
Expand Down

0 comments on commit ea60d90

Please sign in to comment.