Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hook.pipelinesascode.com now, smee.io is not active anymore #1196

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Mar 17, 2023

Changes

let's use our own, spun up gosmee on https://hook.pipelinesascode.com
smee.io may be down for quite a while probot/smee.io#137

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@timneedham
Copy link

timneedham commented Mar 17, 2023

Hi @chmouel ,

As someone who is just dabbling with GitHub apps, with next-to-zero infrastructure knowledge, Smee.io was super useful.
So thanks for doing this, it's really helpful.

@chmouel
Copy link
Member Author

chmouel commented Mar 17, 2023

@timneedham glad it's useful for you, it's not battle tested with large load yet so may have some hiccups under large loads but hopefully it should be just working

Copy link
Member

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@savitaashture savitaashture merged commit 7ca41da into openshift-pipelines:main Mar 23, 2023
@chmouel chmouel deleted the hook-pac branch March 23, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants