fix: Validate Repository URL on creation #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmouel
force-pushed
the
validate-url
branch
2 times, most recently
from
587b5b4 to
771680f
Compare
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
zakisk
reviewed
Feb 12, 2025
chmouel
force-pushed
the
validate-url
branch
from
771680f to
8bc304d
Compare
zakisk
reviewed
Feb 12, 2025
When creating the repository, the URL must be set and must have a valid scheme (http or https). Let's add a check on the webhook to make sure the user has provider a proper URL. We make the global repository URL mandatory compared to before, but since we are TP for global repository, we can make still change that behaviour. Fixes openshift-pipelines#1852 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
force-pushed
the
validate-url
branch
from
8bc304d to
64e83d5
Compare
|
/label fix |
|
✅ Added labels: fix. |
chmouel
added
bug
chmouel
changed the title
|
/test prow-commands |
|
/assign @zakisk |
|
✅ Assigned zakisk for reviews. |
|
/lgtm |
![pipelines-as-code[bot]](https://avatars.githubusercontent.com/in/112592?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Pull Request Approved
Approval Status:
- Required Approvals: 1
- Current Approvals: 1
👥 Approved By:
| Reviewer | Permission | Status |
|---|---|---|
| @zakisk | admin |
✅ |
📝 Next Steps
- All required checks must pass
- Branch protection rules apply
- Get a maintainer to use the
/mergecommand to merge the PR
Thank you for your contributions! 🎉
|
/merge |
pipelines-as-code
bot
merged commit 6540c93
into
openshift-pipelines:main
7 checks passed
|
/help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the repository, the URL must be set and must have a valid scheme (http or https).
Let's add a check on the webhook to make sure the user has provider a proper URL.
Fixes #1852
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
(update the documentation accordingly)