Add istioctl consoleclidownload

[bmangoen]

Goal

Being able to download istioctl from the OpenShift Web Console

TODO

• Need to modify the download URL while the binary will be available
• Fill in the Supported Commands table (will be done in a different PR)

[openshift-ci]

Hi @bmangoen. Thanks for your PR.

I'm waiting for a openshift-service-mesh member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fjglira]

I think once the Nicks PR with the creation of the ossm folder docs is merged this doc should be moved under that folder @bmangoen

[jwendell]

This LGTM. A few comments:

• Can we have a small comment briefly explaining what this file is, I guess this comment could be within the YAML file itself. Bonus point if it has a link to a proper documentation so that others can refer to in the future.
• Although the tool name is istioctl, the description says it is the openshift service mesh tool, not the istio tool. Shouldn't we just stick with the name istio everywhere?
• It seems there are no builds for ARM. Is this on the radar?

[FilipB]

IIRC the bin was uploaded to https://mirror.openshift.com/pub/cgw/servicemesh/latest/ manually. I'm not sure which version was used but we have been building for all 4 arch for 6 months already. So I assume bin for all arch were available at that time and were not uploaded probably?
Currently we build the istioctl bin as a part of must gather image which is also built for all 4 arch. So I guess for TP2 we need to ask to upload bin for all 4 arch. I think we will need a follow up task to test this when it's uploaded.

[FilipB]

We need a follow up task to test the bins for all 4 arch when they are uploaded to https://mirror.openshift.com/pub/cgw/servicemesh/latest

[FilipB]

/ok-to-test

[FilipB]

/hold

[bmangoen]

IIRC the bin was uploaded to https://mirror.openshift.com/pub/cgw/servicemesh/latest/ manually. I'm not sure which version was used but we have been building for all 4 arch for 6 months already. So I assume bin for all arch were available at that time and were not uploaded probably? Currently we build the istioctl bin as a part of must gather image which is also built for all 4 arch. So I guess for TP2 we need to ask to upload bin for all 4 arch. I think we will need a follow up task to test this when it's uploaded.

Yes you're right this binary istioctl-1.23.0-linux-amd64.tar.gz was published manually because of a semantic version issue for TP1.
Agree we need to follow up for adding and testing the other architecture binaries.

[bmangoen]

/retest

[FilipB]

/retest

[FilipB]

/override ci/prow/e2e-kind ci/prow/e2e-ocp-4-16-arm ci/prow/e2e-ocp-4-17 ci/prow/scorecard

[openshift-ci]

@FilipB: Overrode contexts on behalf of FilipB: ci/prow/e2e-kind, ci/prow/e2e-ocp-4-16-arm, ci/prow/e2e-ocp-4-17, ci/prow/scorecard

In response to this:

/override ci/prow/e2e-kind ci/prow/e2e-ocp-4-16-arm ci/prow/e2e-ocp-4-17 ci/prow/scorecard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.