OSSM-8242: use just one istio version so we can build it in cpaas + bump to tp2 #146
Conversation
| OPERATOR_NAME = servicemeshoperator3 | ||
| HUB = quay.io/maistra-dev | ||
| CHANNELS = candidates | ||
| HELM_VALUES_FILE = ossm/values.yaml | ||
| VERSIONS_YAML_FILE = versions.yaml | ||
| VERSIONS_YAML_FILE ?= ossm/versions.yaml |
There was a problem hiding this comment.
The whole purpose of this variable is to make it possible to use another versions file without changing the Makefile. Just set export VERSIONS_YAML_FILE=ossm/versions.yaml before invoking make and you're all set.
There was a problem hiding this comment.
yes but this vendor definition is applied before we do the ?= in the core Makefile so this change is correct - otherwise it wouldn't be possible to overwrite in env var anymore (which @FilipB is doing in his other PR)
There was a problem hiding this comment.
This is a change in default behavior. Now make gen will use ossm/versions.yaml. So to run e2e tests against all versions in ./versions.yaml, we will have to do: 1) VERSIONS_YAML_FILE="versions.yaml" make gen, 2) make test.e2e.ocp
openshift-merge-bot
bot
merged commit c8c95fc
into
openshift-service-mesh:main
To be still testing more istio versions from ./vesions.yaml, there are following changes in OpenShift CI jobs.