Fix CI job KinD network error #167
Conversation
Signed-off-by: Yuanlin Xu <yuanlin.xu@redhat.com>
|
/retest |
|
@yxun: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # Create the docker network beforehand so "kind create cluster" doesn't create it with ipv6 | ||
| echo "Deleting previous KinD docker network" | ||
| docker network rm kind || true | ||
| echo "Creating the docker network for kind" | ||
| docker network create -d=bridge -o com.docker.network.bridge.enable_ip_masquerade=true kind | ||
|
|
There was a problem hiding this comment.
This change will be overridden when the update-common make target is run. Because we copy the entire file from the upstream repo: https://github.com/istio/common-files. So, make sense to push this change to the upstream repository and then update using the make target?
| @@ -165,6 +165,12 @@ function setup_kind_cluster() { | |||
| echo "No existing kind cluster with name ${NAME}. Continue..." | |||
| fi | |||
|
|
|||
| # Create the docker network beforehand so "kind create cluster" doesn't create it with ipv6 | |||
There was a problem hiding this comment.
@yxun kind create cluster creates the kind cluster based on the IP_FAMILY.
Can you explain why this change is required?
|
Let's make functional changes like this one in the community repo |
This PR is following openshift-service-mesh/istio#135 and fixing the CI job error " failed to ensure docker network: command"