config/v1: Add NodeSwap to TechPreviewNoUpgrade #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @rphillips @mrunalp |
|
/lgtm @deads2k for approval |
ehashman
force-pushed
the
swap-support
branch
from
2683683 to
fc66248
Compare
openshift-ci
bot
added
needs-rebase
ehashman
force-pushed
the
swap-support
branch
3 times, most recently
from
f51a0d0 to
6a97702
Compare
openshift-ci
bot
removed
the
needs-rebase
ehashman
force-pushed
the
swap-support
branch
from
6a97702 to
9a4988f
Compare
ehashman
force-pushed
the
swap-support
branch
from
9a4988f to
aa83b5f
Compare
ehashman
changed the title
|
Updated enhancement to remove the featureset per @deads2k's request: openshift/enhancements#975 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ehashman, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openshift/enhancements#902 for OpenShift enhancement details (not yet merged+implementable).
Should be all the implementation currently needed for OCPNODE-618. Enabling swap within a cluster doesn't require any other code changes; configs are detailed in the enhancement above. I was able to get swap working on a cluster-bot cluster using a
CustomNoUpgradefeature gate config.