Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/v1/types_cluster_version: add marketplace capability #1150

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

njhale
Copy link
Contributor

@njhale njhale commented Mar 24, 2022

Add a ClusterVersionCapability representing the Operator Marketplace as
a capability named "marketplace".

Signed-off-by: Nick Hale njohnhale@gmail.com

See also:

Add a ClusterVersionCapability representing the Operator Marketplace as
a capability named "marketplace".

Signed-off-by: Nick Hale <njohnhale@gmail.com>
@njhale
Copy link
Contributor Author

njhale commented Mar 24, 2022

cc @bparees

@perdasilva
Copy link

/approve

…anifest

Signed-off-by: Nick Hale <njohnhale@gmail.com>
@bparees
Copy link
Contributor

bparees commented Mar 24, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@bparees
Copy link
Contributor

bparees commented Mar 24, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, njhale, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@wking
Copy link
Member

wking commented Mar 25, 2022

Prow seems lost.

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2022

@njhale: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timflannagan
Copy link
Contributor

It looks like tide is still gated on the presence of labels that don't seem like they're applicable to a master branch that's outside of any freeze periods?

@timflannagan
Copy link
Contributor

@bparees any idea on whether we can push this through without the need for those backport-related labels?

@wking
Copy link
Member

wking commented Mar 25, 2022

This feature is not part of the no-feature freeze process, so we can add the labels. For precedent, see David doing this for baremetal and Ben doing it for `openshift-samples.

/label px-approved
/label qe-approved
/label docs-approved

But I don't think that will work for me, because the labels need @openshift-patch-managers , and I'm not in that group.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8107b7a into openshift:master Mar 25, 2022
@deads2k
Copy link
Contributor

deads2k commented Mar 25, 2022

/label px-approved /label qe-approved /label docs-approved

But I don't think that will work for me, because the labels need @openshift-patch-managers , and I'm not in that group.

Fear your power!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants