Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-9797: Implementation for new Ingress API introduced in Single Node + Workers enhancement #1151

Merged
merged 1 commit into from
Apr 4, 2022
Merged

MGMT-9797: Implementation for new Ingress API introduced in Single Node + Workers enhancement #1151

merged 1 commit into from
Apr 4, 2022

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Mar 25, 2022 •
edited
Loading

@omertuc omertuc changed the title WIP Implementation for new API introduced in Single Node + Workers enhancement Implementation for new Ingress API introduced in Single Node + Workers enhancement Mar 29, 2022
@omertuc
Copy link
Contributor Author

omertuc commented Mar 29, 2022

/cc @Miciah @dhellmann @JoelSpeed

@omertuc omertuc changed the title Implementation for new Ingress API introduced in Single Node + Workers enhancement MGMT-9797: Implementation for new Ingress API introduced in Single Node + Workers enhancement Mar 29, 2022
JoelSpeed
JoelSpeed reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

config/v1/types_ingress.go Outdated Show resolved Hide resolved
JoelSpeed
JoelSpeed reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
JoelSpeed
JoelSpeed reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@Miciah
Copy link
Contributor

Miciah commented Mar 29, 2022

/lgtm

@deads2k
Copy link
Contributor

deads2k commented Mar 29, 2022

/lgtm

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, Miciah, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@romfreiman
Copy link

Why it's not being merged? Isnt it 4.11 delivery?

@lihongan
Copy link
Contributor

lihongan commented Apr 1, 2022

/label qe-approved
It looks good from QE side.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 1, 2022
@vineetkmr
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 4, 2022
@emilyoneill
Copy link

emilyoneill commented Apr 4, 2022 •
edited
Loading

/label docs-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

@emilyoneill: The label(s) /label doc-approved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/label doc-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@emilyoneill
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 4, 2022
@omertuc
Copy link
Contributor Author

omertuc commented Apr 4, 2022

CI flake
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

@omertuc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 04e1813 into openshift:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@dhellmann dhellmann Awaiting requested review from dhellmann

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@Miciah Miciah

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@omertuc @Miciah @deads2k @romfreiman @lihongan @vineetkmr @emilyoneill @JoelSpeed @openshift-merge-robot