Bug 1894268: Allow users to specify ovnkube join subnet

[pliurh]

Some users need to be able to specify the v4 and v6 join subnets
to use for ovn-k. In particular, they may be already using the
ones that ovn-k uses as default, and they need a way to be able to
specify a different set of subnets as join subnets. This commit
creates the config option for the same. Eventually this will be
consumed by the CNO using rendered bootstrap data and passed to the
ovn-k daemonsets.

Signed-off-by: Peng Liu pliu@redhat.com

[openshift-ci]

Hello @pliurh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label command.

Who should apply these qe/docs/px labels?

• For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
• For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
• For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

[openshift-ci]

@pliurh: This pull request references Bugzilla bug 1894268, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1894268: Allow users to specify ovnkube join subnet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pliurh]

It is to continue the work of #824

[pliurh]

/cc @danwinship

[danwinship]

"join subnet" is meaningless to the user. "is a v4 subnet used internally by ovn-kubernetes".

"Must not overlap with any other subnet being used by OpenShift or by the node network"

Needs a hint about how big it needs to be. (Does it depend on the cluster size? Number of nodes? Number of pods?)

Can this be changed after install or does it need to be set at install time?

[pliurh]

fixed.

[pliurh]

/bugzilla refresh

[openshift-ci]

@pliurh: This pull request references Bugzilla bug 1894268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @huiran0826

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

I suppose if we are going to make this user-configurable, then this PR is fine.
/lgtm

[pliurh]

@jboxman @huiran0826 PTAL.

[huiran0826]

lgtm, @weliang1 Could you help take a look as well?

[pliurh]

This is the story link https://issues.redhat.com/browse/SDN-2593.

[jboxman-rh]

/label docs-approved

[weliang1]

lgtm, @weliang1 Could you help take a look as well?

/lgtm

[weliang1]

/label qe-approved

[knobunc]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc, pliurh, weliang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pliurh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@pliurh: All pull requests linked via external trackers have merged:

• openshift/api#1207

Bugzilla bug 1894268 has been moved to the MODIFIED state.

In response to this:

Bug 1894268: Allow users to specify ovnkube join subnet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.