Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature gate for MCO boot images updates #1646

Merged
merged 1 commit into from
Nov 30, 2023
Merged

add feature gate for MCO boot images updates #1646

merged 1 commit into from
Nov 30, 2023

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Oct 31, 2023

This adds a feature gate for the implementation of openshift/enhancements#1496 by the MCO team. This feature is planned to be released in 4.15 as TechPreview.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

Hello @djoshy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2023
@djoshy djoshy mentioned this pull request Oct 31, 2023
Merged
mrunalp
mrunalp reviewed Nov 1, 2023
View reviewed changes
config/v1/feature_gates.go Outdated
@@ -331,4 +331,14 @@ var (
ResponsiblePerson: "vincepri",
OwningProduct: ocpSpecific,
}

FeatureGateManageBootImages = FeatureGateName("ManageBootImages")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it ManagedBootImages ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (:

@mrunalp
Copy link
Member

mrunalp commented Nov 1, 2023

@deads2k ptal

@djoshy djoshy force-pushed the add-boot-image-feature-gate branch from d85d1f3 to c8a8f66 Compare November 1, 2023 18:23
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@djoshy djoshy force-pushed the add-boot-image-feature-gate branch from c8a8f66 to 9656aae Compare November 10, 2023 14:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2023
@djoshy djoshy force-pushed the add-boot-image-feature-gate branch from 9656aae to f5da7de Compare November 10, 2023 19:53
@djoshy
Copy link
Contributor Author

djoshy commented Nov 13, 2023

@deads2k @mrunalp Could I get some eyes on this, please? We're hoping to land the feature gate in 4.15

@djoshy djoshy mentioned this pull request Nov 17, 2023
Merged
@djoshy djoshy force-pushed the add-boot-image-feature-gate branch from f5da7de to 822316e Compare November 29, 2023 18:45
@deads2k
Copy link
Contributor

deads2k commented Nov 29, 2023

/approve
/hold

holding for MCO ack

/assign @yuqi-zhang

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2023
@djoshy djoshy force-pushed the add-boot-image-feature-gate branch from 822316e to 4493ddf Compare November 29, 2023 18:49
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
yuqi-zhang
yuqi-zhang approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Nov 29, 2023

mco acknowledges

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7f2a17e and 2 for PR HEAD 4493ddf in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit be20875 into openshift:master Nov 30, 2023
16 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202311301049.p0.gbe20875.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.

@djoshy djoshy deleted the add-boot-image-feature-gate branch May 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@djoshy @mrunalp @deads2k @openshift-ci-robot @openshift-bot @yuqi-zhang @openshift-merge-robot