Skip to content

RFE-6242: add OpenStackLoadBalancerParameters to ingress API #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Sep 30, 2024
Merged

RFE-6242: add OpenStackLoadBalancerParameters to ingress API #2027

openshift-merge-bot merged 1 commit into from
Sep 30, 2024

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Sep 12, 2024 •
edited
Loading

Ingress: Add OpenStackLoadBalancerParameters so we can configure the load balancer IP.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2024 •
edited by openshift-ci bot
Loading

@EmilienM: This pull request references RFE-6242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

Hello @EmilienM! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2024
@EmilienM EmilienM force-pushed the RFE-6242 branch 2 times, most recently from 876928c to 4cd89dc Compare September 12, 2024 21:22
mdbooth
mdbooth reviewed Sep 13, 2024
View reviewed changes
@EmilienM EmilienM marked this pull request as ready for review September 13, 2024 12:50
@EmilienM EmilienM changed the title WIP - RFE-6242: add OpenStackLoadBalancerParameters to ingress API RFE-6242: add OpenStackLoadBalancerParameters to ingress API Sep 13, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and knobunc September 13, 2024 12:50
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 13, 2024 •
edited by openshift-ci bot
Loading

@EmilienM: This pull request references RFE-6242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Ingress: Add OpenStackLoadBalancerParameters so we can configure the load balancer IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member Author

EmilienM commented Sep 13, 2024

/cc Miciah
@Miciah I'm tagging you since we discussed about it in the RFE.

Thanks

@EmilienM EmilienM requested a review from mdbooth September 13, 2024 13:51
@openshift-ci openshift-ci bot requested a review from Miciah September 13, 2024 13:51
JoelSpeed
JoelSpeed reviewed Sep 16, 2024
View reviewed changes
JoelSpeed
JoelSpeed reviewed Sep 26, 2024
View reviewed changes
mdbooth
mdbooth reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Sep 30, 2024

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, JoelSpeed, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d671594 into openshift:master Sep 30, 2024
@EmilienM EmilienM deleted the RFE-6242 branch September 30, 2024 16:09
@openshift-bot
Copy link

openshift-bot commented Sep 30, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409301839.p0.gd671594.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@knobunc knobunc Awaiting requested review from knobunc

@Miciah Miciah Awaiting requested review from Miciah

+1 more reviewer

@mdbooth mdbooth mdbooth left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mdbooth mdbooth

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@EmilienM @openshift-ci-robot @JoelSpeed @openshift-bot @mdbooth