Skip to content

[CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 9 commits into from
Oct 9, 2025
Merged

[CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 #2448

openshift-merge-bot merged 9 commits into from
Oct 9, 2025

Conversation

@opokornyy
Copy link
Contributor

@opokornyy opokornyy commented Aug 12, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

Hello @opokornyy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 12, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven August 12, 2025 14:24
@opokornyy
Copy link
Contributor Author

opokornyy commented Aug 12, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Aug 14, 2025

/test verify-feature-promotion

@opokornyy opokornyy force-pushed the CCXDEV-15259-io-v1 branch 2 times, most recently from d7b46b0 to dce787e Compare August 15, 2025 09:48
@opokornyy opokornyy changed the title WIP: promote InsightConfigAPI and OnDemandDataGather to v1 WIP: [CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 Aug 15, 2025
JoelSpeed
JoelSpeed reviewed Aug 18, 2025
View reviewed changes
@opokornyy opokornyy force-pushed the CCXDEV-15259-io-v1 branch 2 times, most recently from 382e32d to c47f3e9 Compare August 19, 2025 08:08
everettraven
everettraven reviewed Aug 19, 2025
View reviewed changes
opokornyy
opokornyy commented Sep 1, 2025
View reviewed changes
@opokornyy
Copy link
Contributor Author

opokornyy commented Sep 2, 2025

/retest

JoelSpeed
JoelSpeed reviewed Sep 2, 2025
View reviewed changes
@opokornyy opokornyy force-pushed the CCXDEV-15259-io-v1 branch 2 times, most recently from c3bd449 to 43fc93f Compare September 8, 2025 13:29
@opokornyy
Copy link
Contributor Author

opokornyy commented Sep 9, 2025

/retest

@everettraven
Copy link
Contributor

everettraven commented Sep 9, 2025

@opokornyy Is this still WIP? If not, would you mind dropping the WIP: from the title?

@opokornyy opokornyy changed the title WIP: [CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 [CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 Sep 10, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2025
@opokornyy
Copy link
Contributor Author

opokornyy commented Sep 10, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Sep 10, 2025

@opokornyy Is this still WIP? If not, would you mind dropping the WIP: from the title?

Sure, I forgot to drop that. Should I still keep it as a draft as well?

@everettraven
Copy link
Contributor

everettraven commented Sep 10, 2025 •
edited
Loading

Sure, I forgot to drop that. Should I still keep it as a draft as well?

If you think this is ready to review for merge, it should not be a draft. If this is something you don't yet want reviews on a draft is appropriate.

@opokornyy
Copy link
Contributor Author

opokornyy commented Sep 10, 2025

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2025

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed, ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opokornyy opokornyy mentioned this pull request Oct 6, 2025
Merged
5 tasks
@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 6, 2025

/retest-required

@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 6, 2025

/retest

1 similar comment
@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 7, 2025

/retest

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 7, 2025

/retest-required

1 similar comment
@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 7, 2025

/retest-required

@deepsm007
Copy link
Contributor

deepsm007 commented Oct 7, 2025

/test e2e-azure

@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 8, 2025

/retest

3 similar comments
@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 8, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 8, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 8, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Oct 9, 2025

/test okd-scos-e2e-aws-ovn

@BaiyangZhou
Copy link

BaiyangZhou commented Oct 9, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@BaiyangZhou: Only users can be targets for the /verified later command.

In response to this:

/verified later by @BaiyangZhou

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@BaiyangZhou
Copy link

BaiyangZhou commented Oct 9, 2025

/verified later @BaiyangZhou

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@BaiyangZhou: This PR has been marked to be verified later by @BaiyangZhou.

In response to this:

/verified later @BaiyangZhou

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 9, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@opokornyy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 610b8c6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 595e66a into openshift:master Oct 9, 2025
27 of 28 checks passed
opokornyy added a commit to opokornyy/api that referenced this pull request Dec 1, 2025
@opokornyy
Revert "Merge pull request openshift#2448 from opokornyy/CCXDEV-15259…
0bbaea9 
…-io-v1"

This reverts commit 595e66a, reversing
changes made to 172bfaf.
openshift-merge-bot bot added a commit that referenced this pull request Dec 2, 2025
@openshift-merge-bot
Merge pull request #2608 from opokornyy/revert-insights-v1
02f6733 
Revert "Merge pull request #2448 from opokornyy/CCXDEV-15259-io-v1"
opokornyy added a commit to opokornyy/api that referenced this pull request Dec 5, 2025
@opokornyy
Reapply "Merge pull request openshift#2448 from opokornyy/CCXDEV-1525…
bad65c2 
…9-io-v1"

This reverts commit 0bbaea9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@everettraven everettraven everettraven approved these changes

@deads2k deads2k Awaiting requested review from deads2k

+1 more reviewer

@ncaak ncaak ncaak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

@everettraven everettraven

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@opokornyy @everettraven @JoelSpeed @openshift-ci-robot @deepsm007 @BaiyangZhou @ncaak