Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/v1: New Release type for ClusterVersionStatus #521

Merged

Commits on Jul 24, 2020

  1. config/v1: New Release type for ClusterVersionStatus

    This commit adds the ability to store release metadata, implementing
    openshift/enhancements@2eb16cf80d
    (enhancements/update/available-update-metadata: Propose a new
    enhancement, 2020-07-20, openshift/enhancements#123) as adjusted by
    openshift/enhancements@12eff48079
    (enhancements/update/available-update-metadata: 'url' docstring
    context, 2020-07-21, openshift/enhancements#408).  For example the
    list of channels that a release is in:
    
      $ curl -sH 'Accept:application/json' 'https://api.openshift.com/api/upgrades_info/v1/graph?channel=stable-4.2' | jq -r '.nodes[] | select(.version == "4.2.4").metadata["io.openshift.upgrades.graph.release.channels"] | split(",")[]'
      candidate-4.2
      fast-4.2
      stable-4.2
    
    That will allow the console and other downstream tooling to expose a
    list of channels available to a given cluster right now, instead of
    hard-coding an expected list [1].  This will account for things like
    phased releases, where we may not recommend an upgrade for your
    particular stable-4.2 cluster even though we are recommending the
    upgrade for other stable-4.2 clusters.
    
    Pivoting around this retyping in Go will require consumer bumps, but I
    don't think it's a breaking change because the only YAML removal is
    'force', which is meaningless in AvailableUpdates.  So I don't think
    this needs to count as a backwards-compat-breaking schema bump.
    
    Autogenerated bumps via:
    
      $ unset GOBIN  # vendor/k8s.io/code-generator/generate-groups.sh and such require "${GOPATH}/bin/deepcopy-gen"
      $ go get k8s.io/gengo/examples/deepcopy-gen
      $ hack/update-deepcopy.sh
      $ hack/update-swagger-docs.sh
      $ make update-codegen-crds
    
    [1]: openshift/console#2935
    wking committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    575f8d2 View commit details
    Browse the repository at this point in the history