Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-407: operator/ingress: Add ELB connection idle timeout #730

Merged
merged 1 commit into from
Apr 29, 2022
Merged

NE-407: operator/ingress: Add ELB connection idle timeout #730

merged 1 commit into from
Apr 29, 2022

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Sep 1, 2020

  • operator/v1/types_ingress.go (AWSClassicLoadBalancerParameters): Add ConnectionIdleTimeoutSeconds field.
  • operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:
  • operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

Related to openshift/enhancements#461.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To complete the pull request process, please assign sjenning
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 555200e to 65ef420 Compare September 1, 2020 22:49
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 31, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Apr 6, 2022

/reopen
/remove-lifecycle rotten

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@Miciah: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot reopened this Apr 6, 2022
@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 6, 2022
@Miciah Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 65ef420 to 5cc1aaf Compare April 6, 2022 23:12
@Miciah
Copy link
Contributor Author

Miciah commented Apr 6, 2022

Rebased.

@Miciah Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 5cc1aaf to 0d2b868 Compare April 6, 2022 23:14
@Miciah
Copy link
Contributor Author

Miciah commented Apr 6, 2022

Updated to match the current version of the enhancement PR.

JoelSpeed
JoelSpeed reviewed Apr 12, 2022
View reviewed changes
operator/v1/types_ingress.go Outdated
// +kubebuilder:validation:Optional
// +kubebuilder:validation:Format=duration
// +optional
ConnectionIdleTimeout *metav1.Duration `json:"connectionIdleTimeout"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need an omitempty?

@Miciah Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch 2 times, most recently from 05c0dbc to 6fa7075 Compare April 12, 2022 13:21
JoelSpeed
JoelSpeed reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@Miciah
Copy link
Contributor Author

Miciah commented Apr 12, 2022 

Trying to pull registry.build02.ci.openshift.org/ci/managed-clonerefs@sha256:d4f56ce76ea8cacb4f39b1cf7abaf2de8ac64274759bb94dc6341ffbc3f297f1...
error: error creating buildah builder: initializing source docker://registry.build02.ci.openshift.org/ci/managed-clonerefs@sha256:d4f56ce76ea8cacb4f39b1cf7abaf2de8ac64274759bb94dc6341ffbc3f297f1: pinging container registry registry.build02.ci.openshift.org: Get "https://registry.build02.ci.openshift.org/v2/": dial tcp: i/o timeout
error while getting build logs, could not retrieve build pod ci-op-pg9kfbhj/src-build : pod "src-build" not found�[36mINFO�[0m[2022-04-12T13:23:50Z] Ran for 1m18s

/test verify-deps

@Miciah Miciah changed the title operator/ingress: Add ELB connection idle timeout NE-407: operator/ingress: Add ELB connection idle timeout Apr 13, 2022
@Miciah Miciah mentioned this pull request Apr 22, 2022
Merged
2 tasks
@jldohmann
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 23, 2022
@quarterpin
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 26, 2022
@CFields651
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 29, 2022
@deads2k
Copy link
Contributor

deads2k commented Apr 29, 2022

/approve

/hold

hold pending link to why we cannot use non-pointer.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2022
@Miciah
operator/ingress: Add ELB connection idle timeout
82a1f62 
* operator/v1/types_ingress.go (AWSClassicLoadBalancerParameters): Add
ConnectionIdleTimeout field.
* operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:
* operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.
@Miciah Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 6fa7075 to 82a1f62 Compare April 29, 2022 22:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@deads2k
Copy link
Contributor

deads2k commented Apr 29, 2022

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b25f69a into openshift:master Apr 29, 2022
@Miciah Miciah mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@eparis eparis Awaiting requested review from eparis

Assignees

@deads2k deads2k

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Miciah @openshift-ci-robot @openshift-bot @jldohmann @quarterpin @CFields651 @deads2k @JoelSpeed @openshift-merge-robot