Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/v1/types_cluster_version: Make Update properties omitempty #992

Closed
wants to merge 1 commit into from
Closed

config/v1/types_cluster_version: Make Update properties omitempty #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/v1/types_cluster_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,14 +236,14 @@ type Update struct {
// field is part of spec, version is optional if image is specified.
//
// +optional
Version string `json:"version"`
Version string `json:"version,omitempty"`

// image is a container image location that contains the update. When this
// field is part of spec, image is optional if version is specified and the
// availableUpdates field contains a matching version.
//
// +optional
Image string `json:"image"`
Image string `json:"image,omitempty"`

// force allows an administrator to update to an image that has failed
// verification or upgradeable checks. This option should only
Expand All @@ -253,7 +253,7 @@ type Update struct {
// or potentially malicious sources.
//
// +optional
Force bool `json:"force"`
Force bool `json:"force,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make any sense, the default false is not empty but false, in which case you'll always get that. So I'd propose dropping this. It would only make sense with pointer bool. strings changes are good.

}

// Release represents an OpenShift release image and associated metadata.
Expand Down