overlay node image before bootstrapping if necessary

[jlebon]

As per openshift/enhancements#1637, we're trying
to get rid of all OpenShift-versioned components from the bootimages.

This means that there will no longer be oc, kubelet, or crio
binaries for example, which bootstrapping obviously relies on.

To adapt to this, the OpenShift installer now ships a new
node-image-overlay.service in its bootstrap Ignition config. This
service takes care of pulling down the node image and overlaying it,
effectively updating the system to the node image version.

Here, we accordingly also adapt assisted-installer so that we run
node-image-overlay.service before starting e.g. kubelet.service and
bootkube.service.

See also: openshift/installer#8742

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[jlebon]

/remove-lifecycle stale

Now that openshift/enhancements#1637 has merged, we will need this. I'll leave it in draft for now until I can rebase and retest it, but feel free to start reviewing.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon
Once this PR has been reviewed and has the lgtm label, please assign jhernand for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlebon]

Rebased and verified this still works! Requires openshift/installer#8742.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.35%. Comparing base (34b971a) to head (33d9f10).

Files with missing lines	Patch %	Lines
src/ops/ops.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   55.20%   52.35%   -2.85%     
==========================================
  Files          15       14       -1     
  Lines        3286     2695     -591     
==========================================
- Hits         1814     1411     -403     
+ Misses       1292     1159     -133     
+ Partials      180      125      -55     

Files with missing lines	Coverage Δ
src/ops/ops.go	43.39% <0.00%> (ø)

... and 1 file with indirect coverage changes

[openshift-ci]

@jlebon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-unit-test	33d9f10	link	true	/test edge-unit-test
ci/prow/okd-scos-e2e-aws-ovn	33d9f10	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/edge-e2e-oci-assisted-4-18	33d9f10	link	false	/test edge-e2e-oci-assisted-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.