-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-18105: Update registry.svc.ci.openshift.org to registry.ci.openshift.org (bugzilla #6552) #6553
MGMT-18105: Update registry.svc.ci.openshift.org to registry.ci.openshift.org (bugzilla #6552) #6553
Conversation
Hi @ArthurVardevanyan. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
67a31e8
to
1d9e72c
Compare
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6553 +/- ##
==========================================
+ Coverage 68.42% 68.68% +0.26%
==========================================
Files 247 247
Lines 36425 37644 +1219
==========================================
+ Hits 24924 25857 +933
- Misses 9293 9527 +234
- Partials 2208 2260 +52
|
/retitle NO-ISSUE: (bugzilla #6552) Update registry.svc.ci.openshift.org to registry.ci.openshift.org |
/retest |
@ArthurVardevanyan: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1b666e6
to
a5377d3
Compare
a5377d3
to
d2bba26
Compare
…ci.openshift.org Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
4334cd6
to
b1d8a07
Compare
/lgtm Thanks for your contribution @ArthurVardevanyan @gamli75 I think this should be backported to all branches, would you agree? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArthurVardevanyan, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is an open epic to change this repository https://issues.redhat.com/browse/MGMT-18105 |
/retitle MGMT-18105: Update registry.svc.ci.openshift.org to registry.ci.openshift.org (bugzilla #6552) |
@ArthurVardevanyan: This pull request references MGMT-18105 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ArthurVardevanyan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold |
@gamli75 Yes, we need to add |
…ci.openshift.org (openshift#6553) Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
…egistry.ci.openshift.org (openshift#6553)" This reverts commit 897fb27.
Issue: #6552
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist