[WIP] MGMT-2977 Create cluster-specific minimal iso #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will take a cluster and add the files specified in the discovery ignition patch to the iso as an additional initrd image. This will allow these customizations to take effect before the rootfs is downloaded
This adds a type enum to both the cluster image info and the image creation parameters
This will make it easier to share between the existing logic which creates the archive then uploads it to s3 and the new logic which will write the archive to the fs before bundling it into the minimal iso directly
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
api-review
carbonin
force-pushed
the
add_ignition_files_to_iso
branch
from
4b63649 to
43247e3
Compare
|
Closing this and splitting it into a few separate PRs |
|
Split this into: Left out the bit that creates the new archive with the ignition files because we can get a full installation without it and it applies more to handling static networking than to just being able to use a minimal iso. |
mkowalski
pushed a commit
to mkowalski/assisted-service
that referenced
this pull request
May 21, 2021
Fix world-readable check in sanitychecks.sh
mkowalski
pushed a commit
to mkowalski/assisted-service
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR customizes the minimal iso for a specific cluster.
It adds an option to the iso generation endpoint to request either the minimal or the full iso. Only one can be used at a time, so whichever one was generated most recently will be downloaded.
To generate the cluster ISO we download the minimal iso template from s3 (using a cache) and make two sets of customizations:
- This may or may not be necessary depending on if MGMT-3510 requires it.