CFE-1133: Watch Infrastructure and update AWS tags #137
Conversation
|
@chiragkyal: This pull request references CFE-1133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chiragkyal
force-pushed
the
aws-tags
branch
3 times, most recently
from
3d5641f
to
f413d74
Compare
|
/test images |
|
/retest-required |
|
/test all |
chiragkyal
force-pushed
the
aws-tags
branch
from
afad1c2
to
deb501d
Compare
|
@chiragkyal: This pull request references CFE-1133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
chiragkyal
changed the title
chiragkyal
force-pushed
the
aws-tags
branch
2 times, most recently
from
c177a9c
to
48c649a
Compare
|
/retest-required |
- Added watch on Infrastructure object to detect changes in PlatformStatus.AWS.ResourceTags. - Merged tags from AWSLoadBalancerController.Spec.AdditionalResourceTags and PlatformStatus.AWS.ResourceTags, prioritizing operator spec tags. Signed-off-by: chiragkyal <ckyal@redhat.com>
|
/retest |
Signed-off-by: chiragkyal <ckyal@redhat.com>
|
/assign @alebedev87 |
|
/retest |
|
@chiragkyal: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds support for AWS user tags specified in the platform status. Tags can be managed centrally in the
PlatformStatusand have them automatically applied to resources managed by the ALBC.Infrastructureobject to detect changes in theplatformStatus.AWS.ResourceTagsfield.AWSLoadBalancerController.Spec.AdditionalResourceTagsand thePlatformStatus.AWS.ResourceTagsinto a single list, prioritizing tags from the operator spec.--default-tagsargument.Implements CFE-1133