-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-1133: Watch Infrastructure and update AWS tags #137
base: main
Are you sure you want to change the base?
Conversation
@chiragkyal: This pull request references CFE-1133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3d5641f
to
f413d74
Compare
/test images |
/retest-required |
/test all |
afad1c2
to
deb501d
Compare
@chiragkyal: This pull request references CFE-1133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c177a9c
to
48c649a
Compare
/retest-required |
- Added watch on Infrastructure object to detect changes in PlatformStatus.AWS.ResourceTags. - Merged tags from AWSLoadBalancerController.Spec.AdditionalResourceTags and PlatformStatus.AWS.ResourceTags, prioritizing operator spec tags. Signed-off-by: chiragkyal <ckyal@redhat.com>
/retest |
Signed-off-by: chiragkyal <ckyal@redhat.com>
/assign @alebedev87 |
/retest |
@chiragkyal: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds support for AWS user tags specified in the platform status. Tags can be managed centrally in the
PlatformStatus
and have them automatically applied to resources managed by the ALBC.Infrastructure
object to detect changes in theplatformStatus.AWS.ResourceTags
field.AWSLoadBalancerController.Spec.AdditionalResourceTags
and thePlatformStatus.AWS.ResourceTags
into a single list, prioritizing tags from the operator spec.--default-tags
argument.Implements CFE-1133