OSD-14573-warn-user-for-old-cli #113
Conversation
There was a problem hiding this comment.
Looks great overall.
This would be a good warning-level log for the initializing commands.
login being one, can you also add the checkBackplaneVersion function call to cloud console as well? Because users can view the cloud console without logging into the cluster.
Tafhim
force-pushed
the
OSD-14573-warn-user-for-old-bp
branch
from
33e4916
to
cfe7792
Compare
OSD-14573 - Add nil safety for command and context objects OSD-14573 - Change message level to debug OSD-14573 - Fix version mismatch due to extra characters in GitHub API tags Update cmd/ocm-backplane/login/login.go Co-authored-by: Supreeth Basabattini <sbasabat@redhat.com> OSD-14573 - Move backplane version check functionality to utils OSD-14573 - Add backplane version check to cloud console
Tafhim
force-pushed
the
OSD-14573-warn-user-for-old-bp
branch
from
2ad4327
to
d887c21
Compare
|
@Tafhim: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: supreeth7, Tafhim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
What type of PR is this?
feature
What this PR does / Why we need it?
In order to help users identify version related issue faster, this PR adds a warning message when they attempt to login to a cluster.
Which Jira/Github issue(s) does this PR fix?
OSD-14573
Special notes for your reviewer
Pre-checks (if applicable)