Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-16073 backplane-cli support for monitoring stack for layered… #120

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

MitaliBhalla
Copy link
Contributor

… products

What type of PR is this?

feature
(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

backplane-cli support for monitoring stack for layred products

Which Jira/Github issue(s) does this PR fix?

https://issues.redhat.com/browse/OSD-16073
Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #120 (3c8d64d) into main (42a9cba) will increase coverage by 0.04%.
The diff coverage is 50.20%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   49.65%   49.70%   +0.04%     
==========================================
  Files          43       45       +2     
  Lines        2761     3000     +239     
==========================================
+ Hits         1371     1491     +120     
- Misses       1158     1248      +90     
- Partials      232      261      +29     
Impacted Files Coverage Δ
pkg/monitoring/monitoring.go 40.00% <40.00%> (ø)
cmd/ocm-backplane/monitoring/monitoring.go 89.58% <89.58%> (ø)
cmd/ocm-backplane/root.go 87.09% <100.00%> (+0.43%) ⬆️

@samanthajayasinghe
Copy link
Contributor

/un-hold

@MitaliBhalla MitaliBhalla changed the title WIP: OSD-16073 backplane-cli support for monitoring stack for layered… OSD-16073 backplane-cli support for monitoring stack for layered… Jun 13, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/ocm-backplane/monitoring/monitoring.go Outdated Show resolved Hide resolved
pkg/monitoring/monitoring.go Outdated Show resolved Hide resolved
pkg/monitoring/monitoring.go Outdated Show resolved Hide resolved
pkg/monitoring/monitoring.go Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bmeng
Copy link
Contributor

bmeng commented Jun 14, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit ac6eef6 into openshift:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants