Create config directory if it doesn't exist #124
Conversation
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 49.65% 49.38% -0.27%
==========================================
Files 43 43
Lines 2761 2776 +15
==========================================
Hits 1371 1371
- Misses 1158 1173 +15
Partials 232 232
|
cmd/ocm-backplane/config/set.go
Outdated
| @@ -43,6 +44,13 @@ func setConfig(cmd *cobra.Command, args []string) error { | |||
| bpConfig.SessionDirectory = viper.GetString("session-dir") | |||
| } | |||
|
|
|||
| // Create config directory if it doesn't exist | |||
| if dir, err := os.Stat(path.Dir(configPath)); os.IsNotExist(err) || !dir.IsDir() { | |||
| if err := os.Mkdir(path.Dir(configPath), 0750); err != nil { | |||
There was a problem hiding this comment.
Thanks for asking that question. I had originally done this, but then thought to myself that what if you typo that directory.. do you want it creating a long tree because you typoed the early folder name if you set BACKPLANE_CONFIG explicitly.
The only way to know for sure the intent is to ask the user.. So now I do! And if they confirm, then I'm now using MkdirAll
cblecker
force-pushed
the
config-dir
branch
2 times, most recently
from
ba26a7b
to
b164c27
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
bug
What this PR does / Why we need it?
When setting a config option, if the directory doesn't exist you'll get an error. This ensures the directory is created. Will return an error if it can't create the directory.
Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Pre-checks (if applicable)