Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the golangci yml name #125

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

bmeng
Copy link
Contributor

@bmeng bmeng commented Jun 15, 2023

What type of PR is this?

(bug)

What this PR does / Why we need it?

Update the golangci config file name, and enable some linters by default

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #125 (2944491) into main (b7d3f1a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   49.43%   49.41%   -0.02%     
==========================================
  Files          45       45              
  Lines        3016     3017       +1     
==========================================
  Hits         1491     1491              
- Misses       1264     1265       +1     
  Partials      261      261              
Impacted Files Coverage Δ
pkg/monitoring/monitoring.go 39.79% <0.00%> (-0.21%) ⬇️

... and 7 files with indirect coverage changes

@samanthajayasinghe
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0501085 and 2 for PR HEAD c4b63a0 in total

@mjlshen
Copy link
Contributor

mjlshen commented Jun 15, 2023

/retest

@bmeng
Copy link
Contributor Author

bmeng commented Jun 16, 2023

@mjlshen FYI, as the golangci.yml has incorrect name before, so the gosec linter was not run, and the test failed due to some of the failures. I will need to fix them firstly

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@bmeng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feichashao
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, feichashao, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2fc500d into openshift:main Jun 16, 2023
@bmeng bmeng deleted the golangci branch July 4, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants