Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-15841: Check proxy and API connection if login failed #127

Merged

Conversation

samanthajayasinghe
Copy link
Contributor

@samanthajayasinghe samanthajayasinghe commented Jun 15, 2023

What type of PR is this?

feature

What this PR does / Why we need it?

Check the API connection via HTTP proxy transmission and provide a proper error message to the end user

Which Jira/Github issue(s) does this PR fix?

OSD-15841

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • [] Included documentation changes with PR

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023

@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue.

In response to this:

What type of PR is this?

feature

What this PR does / Why we need it?

Check the API connection via HTTP proxy transmission and provide a proper error message to the end user

Which Jira/Github issue(s) does this PR fix?

Resolves #

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • [] Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023

@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue.

In response to this:

What type of PR is this?

feature

What this PR does / Why we need it?

Check the API connection via HTTP proxy transmission and provide a proper error message to the end user

Which Jira/Github issue(s) does this PR fix?

[_Resolves #OSD-15841](https://issues.redhat.com/browse/OSD-15841)

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • [] Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023

@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue.

In response to this:

What type of PR is this?

feature

What this PR does / Why we need it?

Check the API connection via HTTP proxy transmission and provide a proper error message to the end user

Which Jira/Github issue(s) does this PR fix?

[_Resolves #OSD-15841](https://issues.redhat.com/browse/OSD-15841)

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • [] Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023

@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue.

In response to this:

What type of PR is this?

feature

What this PR does / Why we need it?

Check the API connection via HTTP proxy transmission and provide a proper error message to the end user

Which Jira/Github issue(s) does this PR fix?

OSD-15841

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • [] Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #127 (d27671d) into main (0501085) will increase coverage by 0.18%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   49.43%   49.62%   +0.18%     
==========================================
  Files          45       45              
  Lines        3016     3045      +29     
==========================================
+ Hits         1491     1511      +20     
- Misses       1264     1270       +6     
- Partials      261      264       +3     
Impacted Files Coverage Δ
pkg/cli/config/config.go 57.40% <68.00%> (+9.13%) ⬆️
cmd/ocm-backplane/login/login.go 68.85% <100.00%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes

pkg/cli/config/config.go Outdated Show resolved Hide resolved
pkg/cli/config/config.go Outdated Show resolved Hide resolved
@bmeng
Copy link
Contributor

bmeng commented Jun 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c821eff into openshift:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants