-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-15841: Check proxy and API connection if login failed #127
OSD-15841: Check proxy and API connection if login failed #127
Conversation
@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@samanthajayasinghe: This pull request references OSD-15841 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
aef7f4a
to
a22eb46
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 49.43% 49.62% +0.18%
==========================================
Files 45 45
Lines 3016 3045 +29
==========================================
+ Hits 1491 1511 +20
- Misses 1264 1270 +6
- Partials 261 264 +3
|
a22eb46
to
db9e0ec
Compare
db9e0ec
to
d27671d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, samanthajayasinghe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@samanthajayasinghe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What this PR does / Why we need it?
Check the API connection via HTTP proxy transmission and provide a proper error message to the end user
Which Jira/Github issue(s) does this PR fix?
OSD-15841
Pre-checks (if applicable)