Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-17209: Update backplane cli commands default to warning log level #139

Merged

Conversation

samanthajayasinghe
Copy link
Contributor

@samanthajayasinghe samanthajayasinghe commented Jul 3, 2023

What type of PR is this?

bug

What this PR does / Why we need it?

Showing warning level as default log level

All commands shows error as follows

ocm backplane <sub-command>  ( shows warn logs )

ocm backplane -v <sub-command>  ( shows info logs )

ocm backplane -v=<log-level> <sub-command>  ( shows <log-level> logs )

Which Jira/Github issue(s) does this PR fix?

_Resolves #_https://issues.redhat.com/browse/OSD-17209

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2023

@samanthajayasinghe: This pull request references OSD-17209 which is a valid jira issue.

In response to this:

What type of PR is this?

bug

What this PR does / Why we need it?

Showing info level logs by default

Which Jira/Github issue(s) does this PR fix?

_Resolves #_https://issues.redhat.com/browse/OSD-17209

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2023
@openshift-ci openshift-ci bot requested review from bmeng and feichashao July 3, 2023 01:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #139 (23f528f) into main (f4dfff7) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   48.85%   48.97%   +0.12%     
==========================================
  Files          50       51       +1     
  Lines        3224     3234      +10     
==========================================
+ Hits         1575     1584       +9     
- Misses       1378     1379       +1     
  Partials      271      271              
Impacted Files Coverage Δ
cmd/ocm-backplane/root.go 80.00% <100.00%> (-7.10%) ⬇️
pkg/cli/globalflags/logs.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@samanthajayasinghe samanthajayasinghe force-pushed the console-token branch 3 times, most recently from 663b87d to c62ce85 Compare July 3, 2023 04:46
@samanthajayasinghe samanthajayasinghe changed the title OSD-17209: Update backplane cli commands default log level OSD-17209: Update backplane cli commands default to warning log level Jul 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2023

@samanthajayasinghe: This pull request references OSD-17209 which is a valid jira issue.

In response to this:

What type of PR is this?

bug

What this PR does / Why we need it?

Showing warning level as default log level

All commands shows error as follows

ocm backplane <sub-command>  ( shows warn logs )

ocm backplane -v <sub-command>  ( shows info logs )

ocm backplane -v=<log-level> <sub-command>  ( shows <log-level> logs )

Which Jira/Github issue(s) does this PR fix?

_Resolves #_https://issues.redhat.com/browse/OSD-17209

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/cli/globalflags/logs.go Outdated Show resolved Hide resolved
pkg/cli/globalflags/logs.go Outdated Show resolved Hide resolved
pkg/cli/globalflags/logs.go Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@supreeth7
Copy link
Contributor

Thanks for the changes.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samanthajayasinghe, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit e5a6000 into openshift:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants