Add service and manager flags to backplane session #144
Conversation
mrbarge
force-pushed
the
backplane-session-manager
branch
from
158066c
to
e9c50a0
Compare
|
@mrbarge: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 48.85% 48.86%
=======================================
Files 51 51
Lines 3242 3266 +24
=======================================
+ Hits 1584 1596 +12
- Misses 1387 1397 +10
- Partials 271 273 +2
|
| @@ -373,17 +396,17 @@ func (e *BackplaneSession) initClusterLogin(cmd *cobra.Command) error { | |||
| // Setting up the flags | |||
| err := login.LoginCmd.Flags().Set("multi", "true") | |||
| if err != nil { | |||
| return fmt.Errorf("error occered when setting multi flag %v", err) | |||
| return fmt.Errorf("error occurred when setting multi flag %v", err) | |||
| false, | ||
| "Login to service cluster for the given hosted cluster or mgmt cluster.", | ||
| ) | ||
|
|
There was a problem hiding this comment.
next time, We should move these two flags to globalOpts and reuse them via login , session and multi-login
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrbarge, samanthajayasinghe, supreeth7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
What type of PR is this?
Feature
What this PR does / Why we need it?
This adds the same
--serviceand--managerflags toocm backplane sessionthat are already in place forocm backplane loginin order to establish a backplane session to the cluster's service or management cluster respectively.I use
backplane sessionalmost exclusively these days, but I miss these flags frombackplane loginquite a lot.Pre-checks (if applicable)