OSD-12531: Replacing GetScripts with new GetScriptsByCluster API calls

[thavlice]

What type of PR is this?

Feature (changing command to use new API)

What this PR does / Why we need it?

Changing API calls to use GetScriptsByCluster instead of GetScripts due to a bug for two comannds:

• describe
• list

The API call semantic is the same but with added clusterId in the API call.
Furthermore, clusterKey to clusterId transformation and loading from config file added.
Provided unit tests modified in accordance with the new behavior.

Which Jira/Github issue(s) does this PR fix?

Resolves OSD-12531

Special notes for your reviewer

Tests were modified as the expected behavior changed.

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

[openshift-ci-robot]

@thavlice: This pull request references OSD-12531 which is a valid jira issue.

In response to this:

What type of PR is this?

Feature (changing command to use new API)

What this PR does / Why we need it?

Changing API calls to use GetScriptsByCluster instead of GetScripts due to a bug for two comannds:

• describe
• list

The API call semantic is the same but with added clusterId in the API call.
Furthermore, clusterKey to clusterId transformation and loading from config file added.
Provided unit tests modified in accordance with the new behavior.

Which Jira/Github issue(s) does this PR fix?

Resolves OSD-12531

Special notes for your reviewer

Tests were modified as the expected behavior changed.

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[supreeth7]

@thavlice can you create a follow-up Jira to phase out the old /backplane/scripts verb once this change has been adapted?

[supreeth7]

@bmeng can you take a look here?

[samanthajayasinghe]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samanthajayasinghe, supreeth7, thavlice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [supreeth7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[supreeth7]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD f26d255 and 2 for PR HEAD d21f193 in total

[codecov-commenter]

Codecov Report

Merging #149 (d21f193) into main (c1ee3b3) will increase coverage by 2.13%.
The diff coverage is 60.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   48.86%   51.00%   +2.13%     
==========================================
  Files          51       51              
  Lines        3266     3476     +210     
==========================================
+ Hits         1596     1773     +177     
- Misses       1397     1411      +14     
- Partials      273      292      +19     

Impacted Files	Coverage Δ
cmd/ocm-backplane/script/describeScript.go	79.22% <60.00%> (-3.39%)	⬇️
cmd/ocm-backplane/script/listScripts.go	68.62% <60.00%> (-3.47%)	⬇️

... and 5 files with indirect coverage changes

[openshift-ci]

@thavlice: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.