Fix usage of global opts in backplane session #159
Conversation
mrbarge
force-pushed
the
fix-globalopts-session
branch
from
f40c6cb
to
1e4194b
Compare
|
@mrbarge: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 49.52% 49.50% -0.02%
==========================================
Files 51 51
Lines 3352 3351 -1
==========================================
- Hits 1660 1659 -1
Misses 1412 1412
Partials 280 280
|
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feichashao, mrbarge, samanthajayasinghe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
What type of PR is this?
Bug
What this PR does / Why we need it?
PR #148 moved the
--managerand--sessionflags to global options, but these do not get set inbackplane sessionwhen used. This is because thesession's internal options boolean variables are separate to those in theglobalOptsstruct, so they're never going to get set to what gets set inglobalOpts.The fix is straightforward, just add the global opts to
session's own options struct as a pointer.