Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --debug-file flag for 'cloud assume' command #169

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Aug 2, 2023

What type of PR is this?

feature

What this PR does / Why we need it?

Adds the ability to manually provide the role assume sequence to the cloud assume command. This is intended to allow test of changes in stage and integration environments.

Which Jira/Github issue(s) does this PR fix?

OSD-17196

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #169 (73ff277) into main (0794c98) will decrease coverage by 0.17%.
Report is 2 commits behind head on main.
The diff coverage is 5.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   49.59%   49.43%   -0.17%     
==========================================
  Files          51       51              
  Lines        3353     3366      +13     
==========================================
+ Hits         1663     1664       +1     
- Misses       1411     1423      +12     
  Partials      279      279              
Files Changed Coverage Δ
cmd/ocm-backplane/cloud/assume.go 7.24% <5.88%> (+0.10%) ⬆️

@AlexVulaj AlexVulaj changed the title add --debug-file flag for 'cloud assume' command (WIP) add --debug-file flag for 'cloud assume' command Aug 3, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2023
@AlexVulaj
Copy link
Contributor Author

/hold

May have found a potential issue.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@AlexVulaj AlexVulaj changed the title (WIP) add --debug-file flag for 'cloud assume' command add --debug-file flag for 'cloud assume' command Aug 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2023
@AlexVulaj AlexVulaj force-pushed the assume-debug branch 2 times, most recently from 73ff277 to 4eeb14b Compare August 3, 2023 19:57
@AlexVulaj
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@samanthajayasinghe
Copy link
Contributor

@AlexVulaj Thanks for adding cloud assume command , Can you pls add some unit tests to cover the new flag and the cloud assume command? currently, It covers only 7.35%

@AlexVulaj
Copy link
Contributor Author

@samanthajayasinghe I added some tests in my latest commit - let me know if these suffice!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@samanthajayasinghe
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@bmeng
Copy link
Contributor

bmeng commented Aug 10, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, bmeng, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit bf43a6a into openshift:main Aug 10, 2023
@AlexVulaj AlexVulaj deleted the assume-debug branch August 10, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants