-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --debug-file flag for 'cloud assume' command #169
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 49.59% 49.43% -0.17%
==========================================
Files 51 51
Lines 3353 3366 +13
==========================================
+ Hits 1663 1664 +1
- Misses 1411 1423 +12
Partials 279 279
|
/hold May have found a potential issue. |
73ff277
to
4eeb14b
Compare
/unhold |
@AlexVulaj Thanks for adding |
@samanthajayasinghe I added some tests in my latest commit - let me know if these suffice! |
@AlexVulaj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexVulaj, bmeng, samanthajayasinghe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
feature
What this PR does / Why we need it?
Adds the ability to manually provide the role assume sequence to the
cloud assume
command. This is intended to allow test of changes in stage and integration environments.Which Jira/Github issue(s) does this PR fix?
OSD-17196
Special notes for your reviewer
Pre-checks (if applicable)