Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-17611 : Adding BP-CLI release cycle info #189

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

MitaliBhalla
Copy link
Contributor

@MitaliBhalla MitaliBhalla commented Aug 24, 2023

What type of PR is this?

documentation
(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

As a part of OSD-17611, adds info on BP-CLI release cycle

Which Jira/Github issue(s) does this PR fix?

OSD-17611
Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from bmeng and Tafhim August 24, 2023 12:08
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Merging #189 (180b63a) into main (691eb6f) will not change coverage.
Report is 10 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   51.11%   51.11%           
=======================================
  Files          51       51           
  Lines        3365     3365           
=======================================
  Hits         1720     1720           
  Misses       1364     1364           
  Partials      281      281           

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Updating message

Addressing review
@bmeng
Copy link
Contributor

bmeng commented Aug 31, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 265ba04 into openshift:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants