Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-18058 : Adding a new interactive shell session when we do debug with elevate command #211

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Dee-6777
Copy link
Contributor

What type of PR is this?

bug

What does this PR do / Why do we need it?

It fixes a bug that occurs when someone attempts to run ocm backplane elevate "[OHSS-1111]" -- debug node/[nodename]. This PR will help open a new interactive shell whenever one tries to run and no longer it will just spin up the debug command and instantly exits.

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-18058

Special notes for your reviewer

It works exactly as the oc debug command and might lag while running in the first attempt and throw a timeout error but this is nothing to worry about oc debug does the same.

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@codecov-commenter
Copy link

Codecov Report

Merging #211 (cfb3253) into main (265ba04) will increase coverage by 0.42%.
Report is 19 commits behind head on main.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   51.11%   51.53%   +0.42%     
==========================================
  Files          51       51              
  Lines        3365     3419      +54     
==========================================
+ Hits         1720     1762      +42     
- Misses       1364     1365       +1     
- Partials      281      292      +11     
Files Coverage Δ
pkg/elevate/elevate.go 82.60% <66.66%> (-3.11%) ⬇️

... and 7 files with indirect coverage changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@Dee-6777: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/scan-optional cfb3253 link false /test scan-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bmeng
Copy link
Contributor

bmeng commented Sep 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, Dee-6777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit f08ab67 into openshift:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants