-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSD-19019] Enable bp-cli to consume warning header from bp API's response #236
[OSD-19019] Enable bp-cli to consume warning header from bp API's response #236
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 51.72% 51.69% -0.04%
==========================================
Files 51 51
Lines 3447 3449 +2
==========================================
Hits 1783 1783
- Misses 1370 1371 +1
- Partials 294 295 +1
|
pls add a unit test to cover the new changes |
c34a721
to
b19141f
Compare
Since the MR for validating clusterversion in backplane-api has been merged, can we merge this interdependent PR-236 (which just to consume a custom warning header I defined in the API to log/print warning messages when end-user doesn't specify clusterVersions for managed-script in metadata.yaml) first. We have a separate task https://issues.redhat.com/browse/OSD-19020 for writing test cases and I will add test case for bp-cli part accordingly. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, samanthajayasinghe, xiaoyu74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xiaoyu74: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What does this PR do / Why we need it?
To have bp-cli enabled to consume the warning header from bp-API's response, so that, when running managed-script with
ocm-backplane
, it can post warnings if theclusterVersions
is not specified in the metadata.yaml but still allow the script continue execute.It's interdependent with the MR-303