Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-19019] Enable bp-cli to consume warning header from bp API's response #236

Merged

Conversation

xiaoyu74
Copy link
Contributor

@xiaoyu74 xiaoyu74 commented Oct 25, 2023

What type of PR is this?

feature

What does this PR do / Why we need it?

To have bp-cli enabled to consume the warning header from bp-API's response, so that, when running managed-script with ocm-backplane, it can post warnings if the clusterVersions is not specified in the metadata.yaml but still allow the script continue execute.

It's interdependent with the MR-303

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@xiaoyu74 xiaoyu74 marked this pull request as ready for review October 25, 2023 23:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@xiaoyu74 xiaoyu74 changed the title Test to have bp-cli enabled to consume warning header from bp API's response Enabled bp-cli to consume warning header from bp API's response Oct 25, 2023
@xiaoyu74 xiaoyu74 changed the title Enabled bp-cli to consume warning header from bp API's response Enable bp-cli to consume warning header from bp API's response Oct 25, 2023
@xiaoyu74 xiaoyu74 changed the title Enable bp-cli to consume warning header from bp API's response [OSD-19019] Enable bp-cli to consume warning header from bp API's response Oct 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #236 (dc54e07) into main (56b27b7) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   51.72%   51.69%   -0.04%     
==========================================
  Files          51       51              
  Lines        3447     3449       +2     
==========================================
  Hits         1783     1783              
- Misses       1370     1371       +1     
- Partials      294      295       +1     
Files Coverage Δ
cmd/ocm-backplane/managedJob/createManagedJob.go 72.36% <33.33%> (-0.97%) ⬇️

@samanthajayasinghe
Copy link
Contributor

pls add a unit test to cover the new changes

@xiaoyu74 xiaoyu74 force-pushed the test_backplane_api_warning_header branch from c34a721 to b19141f Compare November 7, 2023 21:13
@xiaoyu74
Copy link
Contributor Author

xiaoyu74 commented Nov 13, 2023

pls add a unit test to cover the new changes

Since the MR for validating clusterversion in backplane-api has been merged, can we merge this interdependent PR-236 (which just to consume a custom warning header I defined in the API to log/print warning messages when end-user doesn't specify clusterVersions for managed-script in metadata.yaml) first.

We have a separate task https://issues.redhat.com/browse/OSD-19020 for writing test cases and I will add test case for bp-cli part accordingly.

@samanthajayasinghe
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@bmeng
Copy link
Contributor

bmeng commented Nov 14, 2023

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, samanthajayasinghe, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a3e6e8 into openshift:main Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants