Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure region is always present for credentials and console links #243

Merged

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Nov 1, 2023

What type of PR is this?

bug

What this PR does / Why we need it?

Changes for the new flow made it so that "region" wasn't being set when requesting credentials for old and new clusters, or a console link for new clusters.

Which Jira/Github issue(s) does this PR fix?

Resolves OSD-19492

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@samanthajayasinghe
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
Comment on lines +21 to +22
AwsFederatedSigninEndpointTemplate = "https://%v.signin.aws.amazon.com/federation"
AwsConsoleURL = "https://console.aws.amazon.com/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't adding these URLs, but why do these exist in backplane-cli now? These won't work in general for different partitions (e.g. GovCloud)

Copy link
Contributor Author

@AlexVulaj AlexVulaj Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backplane API handles generating this url for clusters using the old flow. For clusters using isolated backplane flow, that isn't the case. So the CLI is responsible in those instances.

@wanghaoran1988
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, samanthajayasinghe, wanghaoran1988

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit 6a2a0e0 into openshift:main Nov 2, 2023
7 checks passed
@AlexVulaj AlexVulaj deleted the set-region-credentials-console branch November 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants