-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure region is always present for credentials and console links #243
Make sure region is always present for credentials and console links #243
Conversation
@AlexVulaj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
AwsFederatedSigninEndpointTemplate = "https://%v.signin.aws.amazon.com/federation" | ||
AwsConsoleURL = "https://console.aws.amazon.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR isn't adding these URLs, but why do these exist in backplane-cli now? These won't work in general for different partitions (e.g. GovCloud)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backplane API handles generating this url for clusters using the old flow. For clusters using isolated backplane flow, that isn't the case. So the CLI is responsible in those instances.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexVulaj, samanthajayasinghe, wanghaoran1988 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
bug
What this PR does / Why we need it?
Changes for the new flow made it so that "region" wasn't being set when requesting credentials for old and new clusters, or a console link for new clusters.
Which Jira/Github issue(s) does this PR fix?
Resolves OSD-19492
Pre-checks (if applicable)