Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating reviewers list #244

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Dee-6777
Copy link
Contributor

@Dee-6777 Dee-6777 commented Nov 2, 2023

What type of PR is this?

documentation

What this PR does / Why we need it?

This pr will add new members of team thor to the reviewers list for backplane

Which Jira/Github issue(s) does this PR fix?

NA

Special notes for your reviewer

NA

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@bmeng
Copy link
Contributor

bmeng commented Nov 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, Dee-6777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #244 (5ff4d76) into main (6a2a0e0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   51.93%   51.93%           
=======================================
  Files          51       51           
  Lines        3410     3410           
=======================================
  Hits         1771     1771           
  Misses       1345     1345           
  Partials      294      294           

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

@Dee-6777: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 97cbb5d into openshift:main Nov 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants