Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fall back to old flow if new flow fails #245

Merged

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Nov 2, 2023

Hotfix for incident itn-2023-00143

Steps taken to test:

  1. On a cluster that was known to be affected by this incident, run ocm backplane cloud console and ocm backplane cloud credentials
  2. See that the isolated flow was attempted, failed, and fell back to the old flow as evidenced by a message printed to the console.
  3. Take a new cluster that should in fact be using the new flow, run ocm backplane cloud console and ocm backplane cloud credentials
  4. See that the isolated flow was attempted and succeeded without falling back to the old flow.

@iamkirkbater
Copy link
Contributor

Can you enumerate the steps you took to test this for the reviewers please?

@AlexVulaj
Copy link
Contributor Author

@iamkirkbater added

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me as well, thanks for the quick fix @AlexVulaj 🥇

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@cblecker
Copy link
Member

cblecker commented Nov 2, 2023

/approve

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, cblecker, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Merging #245 (0a17482) into main (97cbb5d) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   51.93%   51.76%   -0.17%     
==========================================
  Files          51       51              
  Lines        3410     3421      +11     
==========================================
  Hits         1771     1771              
- Misses       1345     1356      +11     
  Partials      294      294              
Files Coverage Δ
pkg/awsutil/sts.go 55.26% <ø> (ø)
cmd/ocm-backplane/cloud/console.go 47.01% <0.00%> (-1.45%) ⬇️
cmd/ocm-backplane/cloud/credentials.go 62.50% <0.00%> (-3.40%) ⬇️

@openshift-ci openshift-ci bot merged commit 11f9419 into openshift:main Nov 2, 2023
7 checks passed
@AlexVulaj AlexVulaj deleted the fallback-isolated-flow-failure branch November 2, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants