-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fall back to old flow if new flow fails #245
fall back to old flow if new flow fails #245
Conversation
Can you enumerate the steps you took to test this for the reviewers please? |
@iamkirkbater added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me as well, thanks for the quick fix @AlexVulaj 🥇
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexVulaj, cblecker, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AlexVulaj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 51.93% 51.76% -0.17%
==========================================
Files 51 51
Lines 3410 3421 +11
==========================================
Hits 1771 1771
- Misses 1345 1356 +11
Partials 294 294
|
Hotfix for incident itn-2023-00143
Steps taken to test:
ocm backplane cloud console
andocm backplane cloud credentials
ocm backplane cloud console
andocm backplane cloud credentials