Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: update dependencies #256

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

typeid
Copy link
Member

@typeid typeid commented Nov 15, 2023

What type of PR is this?

maintenance

What this PR does / Why we need it?

Bump old dependencies to enable importing in other projects without conflicts.

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Merging #256 (a607dfd) into main (5a3e6e8) will not change coverage.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   51.87%   51.87%           
=======================================
  Files          52       52           
  Lines        3433     3433           
=======================================
  Hits         1781     1781           
  Misses       1357     1357           
  Partials      295      295           
Files Coverage Δ
cmd/ocm-backplane/managedJob/createManagedJob.go 72.36% <100.00%> (ø)
cmd/ocm-backplane/console/console.go 42.38% <0.00%> (ø)

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bmeng
Copy link
Contributor

bmeng commented Nov 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 23570ca into openshift:main Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants