Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use logger for iam changes log message #268

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

typeid
Copy link
Member

@typeid typeid commented Nov 24, 2023

What type of PR is this?

bug

What this PR does / Why we need it?

The fmt.Println log message per default interferes with the -o env. This PR changes the Resolving... output to use the logger which won't affect the below:

export $(ocm backplane cloud credentials $CLUSTER_ID -o env)
bash: export: `resolve...': not a valid identifier

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Copy link
Contributor

@supreeth7 supreeth7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supreeth7, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Merging #268 (54c9e41) into main (d436794) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   48.53%   48.53%           
=======================================
  Files          52       52           
  Lines        3441     3441           
=======================================
  Hits         1670     1670           
  Misses       1510     1510           
  Partials      261      261           
Files Coverage Δ
pkg/awsutil/sts.go 56.25% <0.00%> (ø)

@openshift-merge-bot openshift-merge-bot bot merged commit 5b45914 into openshift:main Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants