Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OCMWrapper interface to ocm package and ClientUtils to backplane-api package #280

Merged

Conversation

samanthajayasinghe
Copy link
Contributor

@samanthajayasinghe samanthajayasinghe commented Dec 4, 2023

What type of PR is this?

cleanup

What this PR does / Why we need it?

  • Moving OCMWrapper from util package to ocm package
  • Moving ClientUtils from util package to ocmbackplane-api package

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Merging #280 (4b7e13e) into main (0b3a66a) will decrease coverage by 0.99%.
Report is 2 commits behind head on main.
The diff coverage is 25.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   47.82%   46.83%   -0.99%     
==========================================
  Files          52       53       +1     
  Lines        3467     3540      +73     
==========================================
  Hits         1658     1658              
- Misses       1548     1621      +73     
  Partials      261      261              
Files Coverage Δ
cmd/ocm-backplane/managedJob/createManagedJob.go 72.36% <100.00%> (ø)
cmd/ocm-backplane/managedJob/deleteManagedJob.go 48.14% <100.00%> (ø)
cmd/ocm-backplane/managedJob/getManagedJob.go 66.15% <100.00%> (ø)
cmd/ocm-backplane/script/describeScript.go 79.22% <100.00%> (ø)
cmd/ocm-backplane/script/listScripts.go 68.62% <100.00%> (ø)
cmd/ocm-backplane/testJob/createTestJob.go 71.15% <100.00%> (ø)
cmd/ocm-backplane/testJob/getTestJob.go 58.33% <100.00%> (ø)
pkg/ocm/ocmWrapper.go 0.00% <ø> (ø)
pkg/utils/cluster.go 88.23% <100.00%> (ø)
cmd/ocm-backplane/cloud/credentials.go 60.81% <66.66%> (ø)
... and 12 more

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash
/approve

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2023
@samanthajayasinghe samanthajayasinghe changed the title Move OCMWrapper interface to ocm package Move OCMWrapper interface to ocm package and ClientUtils to backplane-api package Dec 5, 2023
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bmeng
Copy link
Contributor

bmeng commented Dec 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, mjlshen, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1963e3e into openshift:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants