-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch Backplane API URL via OCM environment #281
Fetch Backplane API URL via OCM environment #281
Conversation
22eaea2
to
587c393
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 46.83% 46.91% +0.08%
==========================================
Files 53 53
Lines 3540 3568 +28
==========================================
+ Hits 1658 1674 +16
- Misses 1621 1633 +12
Partials 261 261
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nicely done! 💯
Requested a few changes/refinements.
283001d
to
fc33eb2
Compare
fc33eb2
to
1198e0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and everything checks out.
A few UI/UX improvement suggestions and this will be good to be merged.
Fetch Backplane URL via OCM environment
1198e0c
to
da7e96c
Compare
@samanthajayasinghe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samanthajayasinghe, supreeth7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
feature
What this PR does / Why we need it?
This PR automatically detect the backplane URL via OCM env and users don't need set BP API URL in the config file
Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/OSD-19188
Resolves #
Special notes for your reviewer
How to test
step 1
step2
step3
Pre-checks (if applicable)