Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to source --multi output #289

Merged

Conversation

Tof1973
Copy link
Contributor

@Tof1973 Tof1973 commented Dec 12, 2023

What type of PR is this?

feature

What this PR does / Why we need it?

When using login --multi, the output cannot be sourced directly.
With this change we will be able to run:

source <(ocm-backplane login multi xxx)

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • [ x] Ran unit tests locally
  • [ x] Validated the changes in a cluster
  • [ x] Included documentation changes with PR

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Merging #289 (25b2d1d) into main (da7e96c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   46.91%   46.91%           
=======================================
  Files          53       53           
  Lines        3568     3568           
=======================================
  Hits         1674     1674           
  Misses       1633     1633           
  Partials      261      261           
Files Coverage Δ
pkg/login/kubeConfig.go 59.37% <100.00%> (ø)

@samanthajayasinghe
Copy link
Contributor

Thanks for improving the usage of multi @Tof1973 ,
FYI , You can use backplane session for multi-cluster login where you don't need to set kubecong manually : ref

@samanthajayasinghe
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@feichashao
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, samanthajayasinghe, Tof1973

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 6411c2f into openshift:main Dec 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants