OSD-19779 Use local monitoring plugin on 4.14+ clusters #292
+289
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/retest |
Tafhim
force-pushed
the
OSD-19779-use-local-monitoring-plugin
branch
from
395467c
to
e44df5a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 46.91% 45.24% -1.68%
==========================================
Files 53 53
Lines 3568 3720 +152
==========================================
+ Hits 1674 1683 +9
- Misses 1633 1769 +136
- Partials 261 268 +7
|
Tafhim
force-pushed
the
OSD-19779-use-local-monitoring-plugin
branch
2 times, most recently
from
1d7df26
to
c8f5353
Compare
Tafhim
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Tafhim
force-pushed
the
OSD-19779-use-local-monitoring-plugin
branch
from
c8f5353
to
420d739
Compare
bmeng
reviewed
Dec 14, 2023
Tafhim
force-pushed
the
OSD-19779-use-local-monitoring-plugin
branch
from
d1603ef
to
1426955
Compare
This commit introduces a temporary nginx configuration and a function to run monitoring-plugin in a separate local container. This change only takes effect on cluster with version 4.14 and above. With this change: - An additional container is run locally for monitoring-plugin - The new container is run under the same network infrastructure of the console cotainer - Both the console container and the monitoring-plugin container run in daemon mode - Both containers use randomly reserved ports to listen for requests - monitoring-plugin container uses an inbuilt nginx server that accepts a mounted nginx configuration. For this reason we generate a temporary nginx configuration in backplane configuration directory and mount that to the container. - When both containers start up successfully, the terminal waits for an interrupt. Upon receiving the interrupt signal, both containers are stopped and removed.
Tafhim
force-pushed
the
OSD-19779-use-local-monitoring-plugin
branch
from
1426955
to
c457949
Compare
|
@Tafhim: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samanthajayasinghe, Tafhim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / Why we need it?
Since 4.14, the
monitoring-pluginis required to be run locally. The plugin is running in cluster as a service so port forwarding is the only way to access it otherwise.This PR sets up the locally running backplane console to include a locally running
monitoring-plugincontainer in it's network and access it via anginxserver. The serer is pre-set in themonitoring-plugincontainer so we don't have other ways to access it.This does not change the behavior for pre-4.14 clusters. It only adds the new container when the cluster is 4.14 and above.
Which Jira/Github issue(s) does this PR fix?
OSD-19779
Special notes for your reviewer
This PR introduces a temporary nginx configuration and a function to run monitoring-plugin in a separate local container.
This change only takes effect on cluster with version 4.14 and above.
With this change:
Pre-checks (if applicable)