Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-20024] Add test case for GetRestConfigAsUser #298

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Tof1973
Copy link
Contributor

@Tof1973 Tof1973 commented Dec 18, 2023

What type of PR is this?

test

What this PR does / Why we need it?

followup of #294

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • [ x] Ran unit tests locally
  • [ na] Validated the changes in a cluster
  • [ na] Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Merging #298 (c452d4c) into main (2e3644c) will increase coverage by 0.39%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   45.45%   45.85%   +0.39%     
==========================================
  Files          53       53              
  Lines        3753     3753              
==========================================
+ Hits         1706     1721      +15     
+ Misses       1777     1757      -20     
- Partials      270      275       +5     

see 1 file with indirect coverage changes

@Tof1973
Copy link
Contributor Author

Tof1973 commented Dec 18, 2023

@samanthajayasinghe, here the PR to add test to cover changes in #294 (review)

cmd/ocm-backplane/login/login_test.go Outdated Show resolved Hide resolved
cmd/ocm-backplane/login/login_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@typeid
Copy link
Member

typeid commented Dec 18, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tof1973, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ef88f84 into openshift:main Dec 18, 2023
7 checks passed
@Tof1973 Tof1973 deleted the add-login-test branch April 23, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants