[OSD-20017] create config file with login --multi even if target config file exists

[Tof1973]

What type of PR is this?

bug

What this PR does / Why we need it?

Without this change, when using login --multi on a cluster where we already did it, but where credentials expired, the connection will not work.

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-20017

Special notes for your reviewer

Pre-checks (if applicable)

• [ x] Ran unit tests locally
• [ x] Validated the changes in a cluster
• [na ] Included documentation changes with PR

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d797914) 45.93% compared to head (8250c2a) 45.89%.
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   45.93%   45.89%   -0.05%     
==========================================
  Files          53       53              
  Lines        3753     3785      +32     
==========================================
+ Hits         1724     1737      +13     
- Misses       1754     1775      +21     
+ Partials      275      273       -2     

Files	Coverage Δ
pkg/login/kubeConfig.go	61.29% <55.55%> (+1.91%)	⬆️

... and 3 files with indirect coverage changes

[typeid]

Generally lgtm, added one suggestion

[xiaoyu74]

Also, given the changes made to the CreateClusterKubeConfig function that it now overwrites the kubeconfig file each time it is called, rather than only creating it if it doesn't exist, we might need to update test cases accordingly.

Apart from that, LGTM, great work @Tof1973 👍

[bmeng]

Cannot understand why it has to check the file existence before writing... cc @samanthajayasinghe please let me know if there is a reason
/lgtm
/label tide/merge-method-squash

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, Tof1973

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bmeng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.