Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect assume-initial-arn from OCM URL #325

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Detect assume-initial-arn from OCM URL #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion cmd/ocm-backplane/cloud/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,15 @@ type namedRoleArn struct {
}

func (cfg *QueryConfig) getIsolatedCredentials(ocmToken string) (aws.Credentials, error) {
const (
productionOCMUrl = "https://api.openshift.com"
productionAssumeInitialArn = "arn:aws:iam::922711891673:role/SRE-Support-Role"
stagingOCMUrl = "https://api.stage.openshift.com"
stagingAssumeInitialArn = "arn:aws:iam::277304166082:role/SRE-Support-Role"
integrationOCMUrl = "https://api.integration.openshift.com"
integrationAssumeInitialArn = "arn:aws:iam::277304166082:role/SRE-Support-Role"
supreeth7 marked this conversation as resolved.
Show resolved Hide resolved
)

if cfg.Cluster.ID() == "" {
return aws.Credentials{}, errors.New("must provide non-empty cluster ID")
}
Expand All @@ -231,7 +240,20 @@ func (cfg *QueryConfig) getIsolatedCredentials(ocmToken string) (aws.Credentials
}

if cfg.BackplaneConfiguration.AssumeInitialArn == "" {
return aws.Credentials{}, errors.New("backplane config is missing required `assume-initial-arn` property")
// If not provided as an override, attempt to automatically set this based on OCM url
switch cfg.OcmConnection.URL() {
case productionOCMUrl:
cfg.BackplaneConfiguration.AssumeInitialArn = productionAssumeInitialArn
case stagingOCMUrl:
cfg.BackplaneConfiguration.AssumeInitialArn = stagingAssumeInitialArn
case integrationOCMUrl:
cfg.BackplaneConfiguration.AssumeInitialArn = integrationAssumeInitialArn
default:
logger.Infof("failed to automatically set assume-initial-arn based on OCM url: %s", cfg.OcmConnection.URL())
return aws.Credentials{}, errors.New("backplane config is missing required `assume-initial-arn` property")
}

logger.Debugf("set assume-initial-arn to: %s", cfg.BackplaneConfiguration.AssumeInitialArn)
}

initialClient, err := StsClient(cfg.BackplaneConfiguration.ProxyURL)
Expand Down