-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log relevant message when a user isn't able to fetch the API URL #330
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 45.97% 43.49% -2.49%
==========================================
Files 53 53
Lines 3772 3971 +199
==========================================
- Hits 1734 1727 -7
- Misses 1764 1987 +223
+ Partials 274 257 -17
|
@supreeth7: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjlshen, supreeth7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Bug
What this PR does / Why we need it?
There are edge case scenarios where a user doesn't have enough permissions such as the BackplaneCLI OCM role to fetch the ClusterService Environment Resource from OCM CS. This results in Backplane CLI abruptly timing out with a connection error message. This PR is an aim to address it from a UX perspective.
Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/OSD-20675
Special notes for your reviewer
Pre-checks (if applicable)