Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log relevant message when a user isn't able to fetch the API URL #330

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

supreeth7
Copy link
Contributor

What type of PR is this?

Bug

What this PR does / Why we need it?

There are edge case scenarios where a user doesn't have enough permissions such as the BackplaneCLI OCM role to fetch the ClusterService Environment Resource from OCM CS. This results in Backplane CLI abruptly timing out with a connection error message. This PR is an aim to address it from a UX perspective.

Which Jira/Github issue(s) does this PR fix?

https://issues.redhat.com/browse/OSD-20675

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fd283b0) 45.97% compared to head (d505ba4) 43.49%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   45.97%   43.49%   -2.49%     
==========================================
  Files          53       53              
  Lines        3772     3971     +199     
==========================================
- Hits         1734     1727       -7     
- Misses       1764     1987     +223     
+ Partials      274      257      -17     
Files Coverage Δ
pkg/ocm/ocmWrapper.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@supreeth7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2024
Copy link
Contributor

openshift-ci bot commented Feb 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 28ed0cd into openshift:main Feb 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants